Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable native tests for funqy due to upstream issue #1539

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Disable native tests for funqy due to upstream issue #1539

merged 1 commit into from
Nov 23, 2023

Conversation

fedinskiy
Copy link
Contributor

Summary

see quarkusio/quarkus#37142 for details

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

michalvavrik
michalvavrik reviewed Nov 22, 2023
View reviewed changes
Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this change in principle. Is build-time analytics native failure also related and should be disabled? I can see OpenShift client in io/quarkus/ts/buildtimeanalytics/AnalyticsUtils.java:31

funqy/knative-events/pom.xml Outdated Show resolved Hide resolved
@fedinskiy
Copy link
Contributor Author

Is build-time analytics native failure also related?

Yes, it downloads openshift-client as well, I disabled it.

@michalvavrik michalvavrik merged commit 0451aae into quarkus-qe:main Nov 23, 2023
7 checks passed
@michalvavrik
Copy link
Member

Thanks!

@fedinskiy fedinskiy deleted the fix/disable-native-funqy branch November 23, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalvavrik michalvavrik michalvavrik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fedinskiy @michalvavrik